LGTM -Sanjay
Evan Layton wrote: > sanjay nadkarni (Laptop) wrote: >> >> A few more comments looking at the updated review. Sorry for not >> catching it earlier. >> There is a mix of strtok_r and strtok. Is this deliberate ? I am >> aware the _r is reentrant version of strok but it appears to be used >> when parsing the same file. > > We parse different lines for different things so that are reasons in > some cases why both are used in the same file but not on the same line. > >> >> be_utils.c: >> There is inconsistency about the delimiter used in strok even when >> parsing menu.lst file. > > These are well beyond the scope of this bug fix so if there is > something in particular that you see as wrong we should probably file > another file a bug. > >> >> 1301: shouldn't strtok use BE_WHITE_SPACE, since according to bug >> 8638, the issue was a tab. > > Yes it should have been BE_WHITE_SPACE, I've changed this. > > -evan > >> >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
