OK. Thanks. Jean
Jack Schwartz wrote: > Hi Jean. > > I talked to Karen about this in person yesterday, and it looks to me > like this can be optimized. I'll experiment and let you all know. > > Thanks, > Jack > > On 01/06/09 09:48, Jean McCormack wrote: > >> Karen Tung wrote: >> >>> Hi Jack, >>> >>> >>> - You wrote the "find()" function in python to replace the "find" >>> command for >>> fixing 5802. That seemed to be kinda complicated. Can you explain why >>> we need all the complicated logic, instead of just use os.walk()? >>> >>> - In bootroot_archive.py, the find() function or os.walk() will >>> return the list of files/directories as a list. >>> You wrote those list to temporary files, and then, just open the file >>> and read >>> in the list, when you are processing the list of files to fiocompress >>> as well >>> as when you process the list of files to overwrite. I think we can >>> skip the >>> temporary files and just manipulate the lists directly. >>> >>> >> I'll have to agree with Karen here. Maybe we're missing something and >> there's a reason >> you didn't use the list? >> >> Jean >> >> >> >>> - The changes in DC-manifest.rng, DC_defs.py, and ai_sparc_image.xml >>> look fine to me. >>> >>> Thanks, >>> >>> --Karen >>> >>> Jack Schwartz wrote: >>> >>> >>>> Hi everyone. >>>> >>>> Please review fixes for adding to the DC manifest a way of not >>>> fiocompressing bootroot files, and an implementation for find using >>>> python. >>>> >>>> 5821 Sparc AI microroot is not fully writable >>>> 5802 system calls to find should be investigated to see if an >>>> os.walk would be better >>>> >>>> http://cr.opensolaris.org/~schwartz/081220.1/webrev/ >>>> >>>> I've built and booted an X86 iso to regression test. For SPARC >>>> testing, I've only booted the sparc bootroot and verified that it >>>> boots. I need someone on the AI team to verify the image more >>>> thoroughly. >>>> >>>> Internally, image is available at >>>> /home/schwartz/gates/ss_fiocompress/automated_installer_image_sparc.iso >>>> >>>> Thanks, >>>> Jack >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
