Jack Schwartz wrote: > Hi Karen. > > Thanks for your review. Comments inline. > > Karen Tung wrote: > >> Hi Jack, >> >> >> - You wrote the "find()" function in python to replace the "find" >> command for >> fixing 5802. That seemed to be kinda complicated. Can you explain why >> we need all the complicated logic, instead of just use os.walk()? >> > I generated a find command which can be used for more than just DC, > being that it is functionality which is applicable all over the place. > It can deliver files only , directories only, or all pathnames. > > Can it be simplified for DC? Yes. DC needs only "all pathnames." If I > strip out the other functionality, we'll save only 19 lines though. > Since these 19 lines buy us extra functionality which may be useful in > the future, why not keep them in? This function is a general-purpose > utility. > > What sparked this conversation was when you showed me in person (being > office-mates has its advantages :) ) a case where my find didn't work > like the find(1) command. My find didn't print links to directories > like find(1) does. I traced this back to os.walk itself, which lists > these pathnames in the returned subdirs list but then doesn't iterate on > them. I now list them in the "all pathnames" case and now both my > finds and the find command return the same files. > > OK. > Copyrights updated and webrev respun. > - Against slim_source: > http://cr.opensolaris.org/~schwartz/081220.1/webrev/ > root_archive.py: - line 108: the message here is not completely correct because we can get to this both with the cpio command or the fiocompress command.
Everything else look good to me now. Thanks, --Karen
