>>> Also, the header doesn't spell out that $sparc, DHTADM and TMP_DHCP >>> are assumed >>> to be set up before this routine is called. >> I don't think that is necessary as they are global. > I respectfully disagree. I suggested this because globals can be > modified under the covers; I think it is good to spell out the > environment required for a routine to execute unless it is obvious. > That said, it's only a suggestion.
You may want to consider making it more than a suggestion. Global variables make for exceptionally brittle interfaces and should be used sparingly, if at all. I haven't reviewed the code to determine if there's a good justification here, but I'd be skeptical. Dave
