Hi Sue,
Susan Sohn wrote: > Hi Jan, > > Thank you very much for your comments. Responses below. > > jan damborsky wrote: >> Hi Sue, >> >> please see my comments below. >> >> Thank you, >> Jan >> >> >> setup-sparc.sh >> -------------- >> >> 51 - since install.conf file containing service name is >> stored in image area, I assume it implies that the image >> can't be configured for more than one service - not sure >> if this might be the issue, just checking since I think >> this limitation doesn't exists for x86 case. > > This is a restriction which is deemed ok for the January milestone and > will be changed later. I see - thank you for clarifying this. > >> 59 - I might recommend to use "install_service" keyword >> instead of "service", so that it is the same as in x86 case. > > Done. I have mentioned this to Sundar and he has already changed his > code to match. Thank you. > >> 125-127 - It seems that it is assumed here that network >> is always C-class type (with 24-bit network prefix). >> What happens if server is configured with different length >> of network address ? > > This assumption is already made in the dhcp code. It looks like bug > 5589 was opened for this issue, but was closed last week. I have > reopened it. ok. Thank you. > > >> installadm-common.sh >> -------------------- >> >> 195-197 - since 'install_boot' option is not >> used by AI client, I think those lines could be removed. > > I didn't know that install_boot wasn't being used. I have removed > those lines. I have recently noticed this. I think it is probably remnant from the first AI preview we neglected to remove. > > Thanks again for the review - webrev is updated. I have looked at the updated webrev and the changes look good. Thank you, Jan > > Sue > >> Susan Sohn wrote: >>> Please review the changes for: >>> >>> 4194 need to make installadm tool changes for SPARC >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4194 >>> >>> which are posted at: >>> >>> http://cr.opensolaris.org/~sohn/4194 >>> >>> Thanks, >>> Sue >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
