Karen Tung wrote: > Hi Jean, > > Here are my comments: > > bootroot_archive.py: > > 309-313: You have the command to get the lofi mount point and execute > the installboot command > all together in the same command. While this works, I think it would > be harder to debug > if something goes wrong. I think it would be more clear to separate > this into 2 commands, > and also check the return code of each of the os.system() calls to > make sure that if there's an error, > it gets dealt with accordingly. I have no issues with breaking this apart. > > post_bootroot_pkg_image_mod: > > This change will leave wanboot for all SPARC. "wanboot" is only > needed for SPARC for AI, > "wanboot" is not needed for SPARC live cd, if we ever do one some day. Need to think about this one some.
Jean > > Thanks, > > --Karen > * > *Jean McCormack wrote: >> Please review the following fixes >> >> >> CR: >> 5887 DC needs to install boot blocks to sparc bootroot >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5887 >> >> 5888 /platform/[sun4u|sun4v]/wanboot is needed in AI image >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5888 >> >> Webrev: >> http://cr.opensolaris.org/~jeanm/slim_5888_5887/ >> >> Jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
