Hi Jean, I looked at your updated webrev. Everything looks good to me now. Thank you for making the changes.
--Karen Jean McCormack wrote: > Karen, > > I've updated the webrev. I've split up the installboot/lofiadm command > into two different commands. > I've also restructured so that the wanboot is only left for ai sparc. > This was done by moving the chunk > of code out of post_bootroot_pkg_image_mod and into the slim_cd and ai > specific scripts. > > Jean > > Karen Tung wrote: > >> Hi Jean, >> >> Here are my comments: >> >> bootroot_archive.py: >> >> 309-313: You have the command to get the lofi mount point and execute >> the installboot command >> all together in the same command. While this works, I think it would >> be harder to debug >> if something goes wrong. I think it would be more clear to separate >> this into 2 commands, >> and also check the return code of each of the os.system() calls to >> make sure that if there's an error, >> it gets dealt with accordingly. >> >> post_bootroot_pkg_image_mod: >> >> This change will leave wanboot for all SPARC. "wanboot" is only >> needed for SPARC for AI, >> "wanboot" is not needed for SPARC live cd, if we ever do one some day. >> >> Thanks, >> >> --Karen >> * >> *Jean McCormack wrote: >> >>> Please review the following fixes >>> >>> >>> CR: >>> 5887 DC needs to install boot blocks to sparc bootroot >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=5887 >>> >>> 5888 /platform/[sun4u|sun4v]/wanboot is needed in AI image >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=5888 >>> >>> Webrev: >>> http://cr.opensolaris.org/~jeanm/slim_5888_5887/ >>> >>> Jean >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
