Hi Sue.
Here are my comments:
create_client.sh:
The original create_client executed ${DIRNAME}/delete-client (at lines
305 - 315). The new setup-tftp-links.sh doesn't. Is this an issue?
setup-tftp-links.sh:
142: The logic here won't work because a fiule can't be both a regular
file and a symlink. The original version of create-client.sh used an
"or" operation here, which makes sense.
installadm-common.sh:
128: clean_entry() does nothing with the new first arg, except determine
whether or not to print a message. Was line 131 left out in the cold?
Thanks,
Jack
Susan Sohn wrote:
> Please review the changes for:
>
> 6055 changes to create-client from 4194 codereview
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6055
>
> which are posted at:
>
> http://cr.opensolaris.org/~sohn/6055
>
> Thanks,
> Sue
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
