Hi Jack,
> Here are my comments:
>
> create_client.sh:
>
> The original create_client executed ${DIRNAME}/delete-client (at lines
> 305 - 315). The new setup-tftp-links.sh doesn't. Is this an issue?
No issue, it basically does the same thing by calling clean_entry and sourcing
the CLEAN file.
> setup-tftp-links.sh:
>
> 142: The logic here won't work because a fiule can't be both a regular
> file and a symlink. The original version of create-client.sh used an
> "or" operation here, which makes sense.
>> 142: The logic here won't work because a fiule can't be both a regular
>> file and a symlink. The original version of create-client.sh used an
>> "or" operation here, which makes sense.
> However, to my dismay, -f responds True to a symlink as well as a file.
> So, the code (which is modelled as below) can work:
>
> 142 if [ -h "${Bootdir}/${BOOT_FILE}" ] ; then
> 143 if [ -f "${Bootdir}/${BOOT_FILE}" ] ; then
>
> When I wrote the comment, I thought the "if on 143 would always be
> false... I retract my statement...
I spoke to Sundar about this part of the code. We have decided to always remove
remove the symlink if it exists. See the webrev for the update.
> installadm-common.sh:
>
> 128: clean_entry() does nothing with the new first arg, except determine
> whether or not to print a message. Was line 131 left out in the cold?
The new arg is just used to print the message. 131 needs to happen regardless.
Sue
> Thanks,
> Jack
>
>
> Susan Sohn wrote:
>> Please review the changes for:
>>
>> 6055 changes to create-client from 4194 codereview
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6055
>>
>> which are posted at:
>>
>> http://cr.opensolaris.org/~sohn/6055
>>
>> Thanks,
>> Sue
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
