Karen Tung wrote: > Hi Jean, > > Here are my comments: > > - Line 402-420. My understanding of this code segment is > that you are getting a list of all the snap shots, and making > sure that the order of the of checkpoints corresponds to the order of the > snapshots list. Your list of checkpoints is built by reading the manifest, > so, I understand that the checkpoints will be in the order that's specified. > How do we ensure that the output of "zfs list...." will follow the same > order? > Right now, it just so happens that they follow the same order. > Is there a rule or something that zfs datasets/snapshots will be listed > in the order they are created? I don't see an option in "zfs list" to sort > the datasets by the time they are created or something. That will > certainly gurantee the output of "zfs list" will follow the order > of things specified in the manifest. I am concern > that if "zfs list" ever change the order of the output, then, our code > won't work. >
Adding "-s creation" to zfs list should order them by creation time. Dave
