Karen Tung wrote: > Jean McCormack wrote: >> Karen Tung wrote: >>> Hi Jean, >>> >>> Thank you for making the changes. I still have a few comments: >>> >>> - line 34: why combine the 3 separate lines into this one line? I >>> don't think we need everything from dc_utils.py. >> Because there is very little in dc_utils.py and I find it annoying to >> have multiple lines as previously done. >> I guess just a person "button". I can change if you really want. > It's less error prone to specify exactly what we want from a module. > So, I think it is better > to have it back the way it used to be. And I changed it before you even asked. > >>> - line 409: I think we don't need to mention the empty snapshot here >> Except that it's kind of important. If you leave the empty snapshot >> in, the functionality doesn't work correctly. > I understand the empty snapshot can't be left in, but that comment > doesn't belong in line 409. > I think it is more appropriate to move it to somewhere in the > DC_snapshot_list() function, > because that's where it filters out the empty snapshot. OK. Can move.
Jean >>> - line 686: why is the "-r" removed from here as well as the >>> finalizer_rollback.py? >> -r is added not removed. The reasoning is that if you wish to >> rollback to a step and you've deleted later steps >> this should be legal. Without the -r it doesn't work. > Yes, you are right. For some reason, I read it backwards. Sorry > about the confusion. > > Thanks, > > --Karen
