Thank you for the review.

sarah
****

Jan Damborsky wrote:
> Hi Sarah,
> 
> 
> On 01/15/10 03:15 PM, Sarah Jelinek wrote:
>>
>>> 876-879, 1867-1870
>>>  - Since I am not sure how controllers[] were initially allocated,
>>>    do we need to take care of freeing the space for last member somehow
>>>    after that move is done ?
>>>
>>
>> We do free space for the "offending" controller later in this function:
>>> cache_free_controller(cp);
>>
>> What I am doing is basically is this:
>>
>> If controller at position 3, associated with disk N is the controller 
>> we want disassociate with disk N, then I start at controller[3] and 
>> assign it to the controller[3 +1], and so on, for all controllers 
>> associated with disk N. The only space I need to free is the 
>> controller[3], which I am doing.
>>
>> Does this answer your question?
> 
> 
> Yes, it does.
> Thank you for clarifying this and making those changes.
> 
> Jan
> 

Reply via email to