Sarah Jelinek wrote: > Hi Jan and Ginnie, > > Could you do a code review for: > > 6795293 libdiskmgt coredump on x86 with devices under mpxio > control/SUN-Universal Xport inbound mangement > > Webrev is here: > > http://cr.opensolaris.org/~sjelinek/6795293/ > > ****Building and Testing done: > -Both sparc and x86 built clean > -Tested on both x86 and sparc: > x86 testing reproduced bug and also shows bug fix > sparc testing for regression testing. Bug does not present > itself on sparc. > > -Reproduced bug and tested fix on oaf627.ireland. This is an x86 > box > with Qlogic FC controllers. > -Tested both mpxio and non-mpxio > -ran ::findleaks. No leaks detected. > > Test output is located here: > > /net/irperf.ireland/export/work/bfu/sjelinek > > The files in this directory are specifically: > ***Bad run(bug is present): > -core.test_td.2664.1263495933.gz-core showing original bug reproduced > -libdiskmgt_bad.txt > -test_td_bad.txt > > ***Good run(bug fixed): > -libdiskmgt_good.txt > -test_td_good.txt > -format.txt - shows output of format to show match with > test_td_good.txt data. > > ***Good run, mpxio disabled(bug fixed): > -libdiskmgt_nonmpxio.txt > -test_td_nonmpxio.txt > -format_nonmpxio.txt - shows output of format to show match with > -test_td_nonmpxio.txt data. > > > thanks, > sarah > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss Sarah,
This looks good to me. I have one questions. 869-884 Is moving items up in the lists creating a memory leak? Joe
