On 01/14/10 05:38 PM, Karen Tung wrote: > Please review my changes to fix the following bugs: > > 12726 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12726> DC and > installers shouldn't require a root password in the packaged /etc/shadow > 12669 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12669> DC errors > about /var/pkg/catalog > 12186 <http://defect.opensolaris.org/bz/show_bug.cgi?id=12186> Deleting > catalog cache needs to be revisited with with catalog v1 > <http://defect.opensolaris.org/bz/show_bug.cgi?id=1> > > http://cr.opensolaris.org/~ktung/12726/ >
ai_sparc_image.xml (and the other manifests): I'd suggest the new parameter closer to the top, before the "rarely configured" signpost (and probably before the package list). pre_boot_archive_pkg_image_mod.py: I'm bothered that we're proliferating mechanisms for setting passwords. ICT presently uses the PasswordFile class from IPS to do essentially the same thing (minus the encryption). I'll leave it to you as to whether you want to reconsider this now or file a bug to deal with it later; comments below in case you stick with this code: 105: Can break from loop at this point 120: we're not saving timezone here; seems this line should be deleted install_utils.py 770: any reason not to just use string.printable? Dave
