On 01/15/10 06:45 PM, Karen Tung wrote: > Hi Dave, > > Thank you for the code review. Please see my response to your comments > below. > > On 01/15/10 07:44 AM, Dave Miner wrote: ... >> install_utils.py >> >> 770: any reason not to just use string.printable? > The reason I can not use string.printable because characters from the salt > should only contain characters from the set [a-zA-Z0-9./] according to > the crypt_unix(5) man page. >
A comment to this effect here would be helpful for future reference. Otherwise all fine, no need to re-review. Dave
