Hi Alex, please see my code review comments below. Also, make sure you follow all steps described in following procedure:
http://www.opensolaris.org/os/project/caiman/Developers/ Namely, you need to have SCA filed before changes could be integrated. Thank you, Jan line 1023 - why is this debug message being removed ? 1116 - please use boolean_t type instead of int: 1116 int drive_is_zvol; 1117 1118 drive_is_zvol = 0; -> 1116 boolean_t drive_is_zvol = B_FALSE; There is no need for 'else' clause on lines 1127-1128, as drive_is_zvol is initialized at the beginning of the function. Also, I might recommend to use strncmp() instead of strstr() to explicitly express the intent to compare beginning of the string - strstr() tries to find the match in whole string. The code might be changed in following way: 1125 if (strstr(devid, "/dev/zvol") != NULL) 1126 drive_is_zvol = 1; 1127 else 1128 drive_is_zvol = 0; -> 1125 if (strncmp(devid, "/dev/zvol", sizeof ("/dev/zvol")) == 0) 1126 drive_is_zvol = B_TRUE; 1131-1133 - these lines should be indented with one more tab Following code might be simplified: 1133 return (drive_is_zvol); 1134 1135 } 1136 1137 return (0); -> 1133 } 1134 return (drive_is_zvol); Alexander Eremin wrote: > Well, webrev updated here: > http://cr.opensolaris.org/~alhazred/5929/webrev/ > > Regards, > > Alex
