Hi Alex,
the updated webrev looks good - I have only two nits:
[1] please use Bug ID and Synopsis as comment when you commit
the changeset, e.g.
$ hg commit -m "5929 libtd should filter out ZFS volumes as disks"
or
$ hg recommit -m "5929 libtd should filter out ZFS volumes as disks"
It then appears as webrev comment.
[2] line 1123 has more than 80 characters - could you please
split it in order to be compliant with
"C Style and Coding Standards for SunOS" ?
For instance
1123 if (strncmp(devid, "/dev/zvol", strlen ("/dev/zvol")) == 0)
->
1123 if (strncmp(devid, "/dev/zvol",
1124 strlen ("/dev/zvol")) == 0)
Continuation line should be half a tab (4 spaces) indented.
Full version of that standard in PDF format can be obtained from
http://opensolaris.org/os/community/on/cstyle.ms.pdf
Also, I assume that you retested the fix after you did the changes -
just checking :-)
I will let the webrev settle over the weekend, so that other people
might take a look as well and if there are no objections, I could integrate
your changes next week.
Thank you,
Jan
Alexander Eremin wrote:
> Thanks Jan,
> pls review updated webrev here:
> http://cr.opensolaris.org/~alhazred/5929/webrev/
