Hi Jack, On Mon, 21 Sep 2009, Jack Schwartz wrote:
> Hi Alok. > > I just have a couple of comments to add to the feedback already sent. > Hopefully these haven't yet been mentioned. Thanks for the review. > usr/src/cmd/auto-install/svc/auto-installer: > > 77: Need to check if ["$AI_AUTO_SHUTDOWN" = "enable" ] before assuming there > is a shutdown. Yep, this was mentioned earlier. Changed. > usr/src/lib/libtransfer/transfer_mode.py: > > 897: if timeout is zero, will still potentially wait for 10 seconds. Good point, will change. Alok > > Thanks, > Jack > > > > On 09/11/09 17:22, Alok Aggarwal wrote: >> This is a code review request for the Bootable AI project [1]. >> >>> From a high level, the changes proposed here are - >> >> a) Refactoring filesystem/root:live-media into the >> following components - >> >> filesystem/root-minimal:live-media (minimal bringup for root fs) >> filesystem/root:live-media (root fs bringup specific to media boot) >> filesystem/root:net (root fs bringup specific to network boot) >> >> b) Refactoring the auto-installer service into - >> >> application/manifest-locator (locate appropriate manifest to use) >> application/auto-installer (invoke the actual auto-install) >> >> c) DC changes to create a bootable sparc image >> >> d) DC changes for creating a custom grub menu >> >> e) Changes to auto-install and the transfer module to have a >> built in timeout for the initial 'pkg' contact >> >> The last one (e) shows up in the webrev but still needs more >> work and testing. I will send a follow on webrev some time next >> week that has (e) in a more finished state. >> >> The webrev location is - >> >> http://cr.opensolaris.org/~aalok/bootable.ai/ >> >> I would like to solicit feedback on this wad by Thursday, 12pm PT. >> If you intend to review this code (or portions of it), please let >> me know so I can plan accordingly. >> >> Thanks, >> Alok >> >> [1] >> http://www.opensolaris.org/os/project/caiman/Bootable_AI_Image/bootable.ai.spec.txt >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >
