Hi Alok,
Sorry for the very tardy response but after our meeting today it
got me thinking about your Python. One thing which is imperative for our
code to someday pylint is that all functionality which executes needs to
be wrapped in functions and called only if called as a program (versus
being imported). See
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Main
Thank you,
Clay
On Fri, 11 Sep 2009, Alok Aggarwal wrote:
> This is a code review request for the Bootable AI project [1].
>
> From a high level, the changes proposed here are -
>
> a) Refactoring filesystem/root:live-media into the
> following components -
>
> filesystem/root-minimal:live-media (minimal bringup for root fs)
> filesystem/root:live-media (root fs bringup specific to media boot)
> filesystem/root:net (root fs bringup specific to network boot)
>
> b) Refactoring the auto-installer service into -
>
> application/manifest-locator (locate appropriate manifest to use)
> application/auto-installer (invoke the actual auto-install)
>
> c) DC changes to create a bootable sparc image
>
> d) DC changes for creating a custom grub menu
>
> e) Changes to auto-install and the transfer module to have a
> built in timeout for the initial 'pkg' contact
>
> The last one (e) shows up in the webrev but still needs more
> work and testing. I will send a follow on webrev some time next
> week that has (e) in a more finished state.
>
> The webrev location is -
>
> http://cr.opensolaris.org/~aalok/bootable.ai/
>
> I would like to solicit feedback on this wad by Thursday, 12pm PT.
> If you intend to review this code (or portions of it), please let
> me know so I can plan accordingly.
>
> Thanks,
> Alok
>
> [1]
> http://www.opensolaris.org/os/project/caiman/Bootable_AI_Image/bootable.ai.spec.txt
>
