Alok,

Just a couple of minor comments ...


usr/src/cmd/auto-install/svc/manifest-locator
---------------------------------------------
242 - Why is the value aimanifest=true to not start auto-installer?

       Can I suggest aimanifest=none instead?



usr/src/cmd/slim-install/svc/live-fs-root-minimal
-------------------------------------------------
90 - Can we explicitly require $MEDIA_BOOT = true here to
      do this?


thanks,
-ethan



Alok Aggarwal wrote:
> I have updated the webrev to accomodate all the code review
> feedback recieved so far, in case any one would like to
> take a look.
> 
> A webrev with changes from the initial webrev is here -
> http://cr.opensolaris.org/~aalok/bootable.ai.coderev.diffs
> 
> A complete webrev is here -
> http://cr.opensolaris.org/~aalok/bootable.ai.coderev
> 
> Thanks,
> Alok
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to