Hi Jan, On Tue, 29 Sep 2009, Jan Damborsky wrote:
> Alok Aggarwal wrote: >> Hi Ethan, >> >> On Fri, 25 Sep 2009, Ethan Quach wrote: >> >>> Alok, >>> >>> Just a couple of minor comments ... >>> >>> >>> usr/src/cmd/auto-install/svc/manifest-locator >>> --------------------------------------------- >>> 242 - Why is the value aimanifest=true to not start auto-installer? >>> >>> Can I suggest aimanifest=none instead? >> >> If "aimanifest=" is specified on the grub line, this > > If the variable doesn't carry any information, I am wondering > if we could leave it out completely. aimanifest can either have a value of "default" or "prompt". If the user chooses to manually edit the value of the variable and make it empty, the above check ensures the correct behavior occurs. > I have gone through the updated webrev and other than that > it looks good. Thanks for taking another look. Alok
