HI Alok.
Thanks for your feedback.
I agree that we should keep tests in similar format to ON. There are
lots of places in ON which keep tests together with the things they are
testing; the example of dtrace which you sight is one. However, some
places in ON don't do this, such as the example of ztest which you sight.
It is important from an organizational point of view to keep tests
together with the things they test; if nothing else, doing this will
provide a logical place to look for the desired tests. What I proposed
supports this.
Thanks,
Jack
On 02/10/09 11:02, Alok Aggarwal wrote:
>
> On Tue, 10 Feb 2009, Jack Schwartz wrote:
>
>> Hi everyone.
>>
>> At this morning's AI meeting we discussed putting unittest
>> information and programs/scripts into the slim_source gate.
>>
>> It is important that there be a structure to this, to prevent sprawl
>> and unorganization. Implementing such a structure now will help
>> maintain gate organization in the future. If we don't, the gate will
>> degenerate.
>>
>> I propose that we put test code and documentation into a
>> subdirectories with an agreed-upon standard name. Each subdirectory
>> will hang off of the directory containing the delivered code being
>> tested. I suggest "unittest". The slim-source gate does not contain
>> any matches on this name currently, and the name is clear.
>>
>> As an example, I have some XML processing code under
>> usr/src/lib/install_utils. I will put my test programs for these
>> modules in usr/src/lib/install_utils/unittest.
>>
>> Code and documents going into the unittest subdirectories (and *only*
>> unittest subdirectories) don't need to be code reviewed.
>
> Given that our eventual goal is to deliver into ON,
> I would say we should mimic the way source code is
> laid out in ON.
>
> If I look at the ON source, some of the dtrace test
> programs live under usr/src/cmd/dtrace/test. Standalone
> test utilities such as ztest for zfs live under their
> separate directory usr/src/cmd/ztest. Each of these
> subdirectories then contain common as well as platform
> specific code.
>
> Alok
