Hi William,

On 02/13/09 15:36, William Schumann wrote:
> New Automated Installer code allows creating partitions of different 
> types.
>
> Place partition type value in element "partition_type".
>
> Allows "FAT32", "DOS16", "SOLARIS", "OPENSOLARIS" or any numeric type 
> specified in fdisk.h

I am not sure, we should distinguish between SOLARIS and OPENSOLARIS
partition, since those both create partition with 0xbf ID. Maybe we
should use only SOLARIS which is more generic.

disk_part.c
-----------
pinfo->content_type is being set according to the partition
ID to be created. I am not sure, if we could assume this.
The reason is that 'content_type' should reflect what the
partition actually contains and should be realized by looking
into the partition.
Since only ID is to be created and no other actions are taken,
I think that 'content_type' should be set to OM_CTYPE_UNKNOWN.

Thank you,
Jan


Reply via email to