William Schumann wrote:
> New Automated Installer code allows creating partitions of different types.
>
> Place partition type value in element "partition_type".
>
> Allows "FAT32", "DOS16", "SOLARIS", "OPENSOLARIS" or any numeric type
> specified in fdisk.h
>
> http://cr.opensolaris.org/~wmsch/bug-6584/
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6584
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Looks good William.
Please confirm my question, which is a possible confusion on my part
My suggestion may just be a style issue but it seemed clearer to me...
Hope this helps!
Joe
Question:
---------
File: usr/src/cmd/auto-install/ai_manifest.rng
Please confirm line 195 correct.
195 <text/>
Just a suggestion:
------------------
File: usr/src/cmd/auto-install/auto_parse.c
Would it seem clearer to negate the logic on line 362 and remove the
continue on line 362?
From:
362 if (errno == 0 && endptr != p[i])
363 continue;
364 auto_debug_print(AUTO_DBGLVL_ERR,
365 "Partition type in manifest
(%s) is "
366 "not a valid number or disk
format.\n",
367 p[i]);
368 *pstatus = 1;
369 free(api);
370 errno = 0;
371 return (NULL);
To:
if (!(errno == 0 && endptr != p[i])) {
auto_debug_print(AUTO_DBGLVL_ERR,
"Partition type in manifest (%s) is "
"not a valid number or disk format.\n",
p[i]);
*pstatus = 1;
free(api);
errno = 0;
return (NULL);
}
