Dave Miner wrote: > Evan Layton wrote: >> Dave Miner wrote: >>> Evan Layton wrote: >>>> Hi, >>>> >>>> I need to get a review the following fix. This simply makes sure that >>>> we grab the current description from the title and add it to the title >>>> line for the new BE. For current OpenSolaris entries this will mean >>>> that the build number from the original BE will show in a new BE's >>>> description. However once 5416 is fixed this will no longer be an >>>> issue. >>>> >> >> It was my understanding that 5416 would remove the build number from >> the description in the title for the original GRUB entry. It was this >> build number that I was referring to as being a problem. However if >> 5416 removes this build number then the description no longer has this >> in it and is no loner an issue. >> > > You're making an assumption there about the fix for 5416 which may or > may not be warranted. It also ignores the effect on all the users who > already have installed and will just be image-updating going forward. > From my perspective, what you propose with this fix is a regression: > having all our non-xVM users end up with mis-labeled menu entries seems > much worse than the current inconvenience suffered by the tiny minority > of xVM users.
I don't see how this is a regression in that these entries are not currently labeled at all other than the BE name which will remain. This just adds the rest of the description line. Also if the user has made changes to the original title line and I come through and just grab the release those changes will be lost. I guess what I could do is check the description against the first string in the release file and if they match (checking the text boot entry as well) then I can grab the new value from /etc/release and replace the description. If they don't match I go with what's already in the description. -evan
