Now that this will not be needed for 2009.06 release I'd like to withdraw this fix until we can do something a bit better. The reason I'm not happy with this fix is because of the special casing that has to be done to support xVM and if another type of entry gets added in the future we would also have to add a special case for that was well. With the work going forward to add a multi-level capability to grub the need for this special casing would be removed. Based on that I would like to defer the fix for this until those grub changes are available.
Thanks! -evan Evan Layton wrote: > Dave Miner wrote: >> Evan Layton wrote: >>> Dave Miner wrote: >>>> Evan Layton wrote: >>>>> Hi, >>>>> >>>>> I need to get a review the following fix. This simply makes sure that >>>>> we grab the current description from the title and add it to the title >>>>> line for the new BE. For current OpenSolaris entries this will mean >>>>> that the build number from the original BE will show in a new BE's >>>>> description. However once 5416 is fixed this will no longer be an >>>>> issue. >>>>> >>> >>> It was my understanding that 5416 would remove the build number from >>> the description in the title for the original GRUB entry. It was this >>> build number that I was referring to as being a problem. However if >>> 5416 removes this build number then the description no longer has this >>> in it and is no loner an issue. >>> >> >> You're making an assumption there about the fix for 5416 which may or >> may not be warranted. It also ignores the effect on all the users who >> already have installed and will just be image-updating going forward. >> From my perspective, what you propose with this fix is a regression: >> having all our non-xVM users end up with mis-labeled menu entries >> seems much worse than the current inconvenience suffered by the tiny >> minority of xVM users. >> >> Dave > > Hi Dave, > > As we discussed on IRC and on the phone, I've updated this so that if > the description in the title line matches what's in the first line of > /etc/release this gets stripped off and removed from the title line of > the new entry. I also added code to make sure if there is anything in > the description after that (like "text boot") that is kept and placed in > the new title line. While testing I also realized that if a description > is passed in anything in the current line will be over written. This > would make it so the "text boot" and any xVM line would have the same > exact description as the first entry (that is when 4061 gets fixed). I > fixed this so that the "text boot" is appended to the line and any xVM > lines are unchanged, other than to place the BE name in the line. > > I've updated the webrev with these changes. > > Thanks! > -evan > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
