Hey Joe, * Joseph J VLcek (Joseph.Vlcek at Sun.COM) wrote: > Please review the fixes for: > > Bug 14081 install-finish needs to stop blowing away filestat.ramdisk > http://defect.opensolaris.org/bz/show_bug.cgi?id=14081 > > The webrev is here: > http://cr.opensolaris.org/~joev/bug14081/ > > This is not a large code change. One ICT has been removed and the > invocation of ICT update_boot_archive has been relocated to later in > the process.
This looks fine to me. I do have one question, you removed the remove_files function completely. Was this filestat.ramdisk file the only file we ever removed? Are we ever likely to need to remove a file (any file) again? I realize we're not running a museum but I'm just wondering if this remove_files function was meant more general purpose, and with your changes it'll be gone completely (though not forgotten in the hg annotation/log I suppose). Cheers, -- Glenn
