* Joseph J VLcek (Joseph.Vlcek at Sun.COM) wrote: > >This looks fine to me. I do have one question, you removed the > >remove_files function completely. Was this filestat.ramdisk file the > >only file we ever removed? Are we ever likely to need to remove a file > >(any file) again? I realize we're not running a museum but I'm just > >wondering if this remove_files function was meant more general purpose, > >and with your changes it'll be gone completely (though not forgotten in > >the hg annotation/log I suppose). > > Hey Glenn, > > Thanks for the feedback! > > Good question. I had thought about that. I went with the "we're not > running a museum" approach. > > Also it was the only file being removed. > > If we end up removing others in the future we could always resurrect > it from mercurial. > > Besides the return code it was using: > "ICT_REMOVE_FILESTAT_RAMDISK_FAILED" gives one the clear > understanding of the limited use this ICT actually had.
Fair enough. I'm fine with this as is. Ship it. -- Glenn
