Hi Sanjay, Thank you for doing the review. Please see my comments inline.
On 02/ 3/10 07:14 PM, sanjay nadkarni (Laptop) wrote: > Hi Karen, > I am curious why are we not using all the profiles from the > image ? For example in > ai_sparc_image.xml, generic_live.xml ? Those profiles are part of the SUNWdistro-const package, which is not part of any of our images. So, unless we want to add SUNWdistro-const package to the images, or move those profiles into a package that's part of the image, we would have to use the copy from the build system, which we assume would have the latest SUNWdistro-const image. If we do decide to put the profiles into a package that is part of the image, this fix would still handle that well, and all we have to change are the manifests. > > Also I am curious if reran the timing for liveCD after these changes. > You mean, the "timing" of liveCD boot up with manifest-import disabled or not? The timing I reported is actually done after these changes are made. It was harder to run the tests before I make the changes. Thanks, --Karen > -Sanjay > > > On 02/ 3/10 05:19 PM, Karen Tung wrote: >> Hi, >> >> I would like to get at least 2 reviewers to look at changes for >> the following 2010.03 stopper. >> >> 5209 <http://defect.opensolaris.org/bz/show_bug.cgi?id=5209> >> Enhancements to the mkrepo script >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5209 >> >> webrev: >> >> http://cr.opensolaris.org/~ktung/5209/ >> >> The following testing has been done: >> >> - Built slim cd image, sparc ai image, x86 ai image. Make sure the >> log files are no longer >> reporting warnings/errors of things this bug fix is correcting. >> >> - Boot up slim cd image, made sure no noticeable performance >> degradation at boot time. >> Performed an install and make sure installed system works well. >> >> - Booted up sun4u and sun4v sparc systems, and made sure the correct >> platform profiles >> are applied. Mary will try to find other type of sparc systems to >> verify further. >> >> - Booted up x86 AI image, and performed install, to make sure changes >> didn't affect that. >> >> >> Thanks, >> >> --Karen >> >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20100204/35afc630/attachment.html>
