On 02/ 4/10 12:31 PM, Glenn Lagasse wrote: > Hey Joe, > > * Joseph J. VLcek (Joseph.Vlcek at Sun.COM) wrote: >> On 02/ 3/10 04:11 PM, Glenn Lagasse wrote: >>> Could I please get two reviewers to have a look at this 2010.03 stopper? >>> >>> 13272 Need to add support for customizing default AI client manifest on >>> AI image for VM construction >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=13272 >>> >>> Webrev: >>> >>> http://cr.opensolaris.org/~glagasse/fixups/ >>> >>> Thanks! >>> >> Looks good Glenn, >> >> Please describe how you tested this. Did you do a full VMC run with >> a modified AI client manifest? > > I did a full VMC run with a modified AI client manifest. Worked > perfectly. > >> Also please update the comment for the new optional argument to >> indicate the argument is not optional, that either the string >> "default" is passed resulting in using the default AI client >> manifest from the image or optionally a path to a modified client >> manifest. Either way the option is required and I think the comment >> should reflect that. > > Done. See my response to Karen. I've updated the webrev as well. > > Thanks for the feedback! >
Thank you Glenn! Sounds good. Joe
