This is a preliminary code review request for a selection of the Install
Service Image Management project (ISIM).
Please provide feedback by the end of next week, Friday 12.December.2010.
Although there is more code in the webrev, for this review, please focus
on the following bits:
ai_image:
---------
Provides a simple common interface for consumers (installadm) to manage
both ISO and pkg(5) based images.
usr/src/cmd/installadm/utils/ai_image.py
usr/src/cmd/installadm/utils/test/test_ai_image.py
Test coverage is currently at over 80%.
host_server:
------------
Currently this is just a skeleton. The intent is to provide a single
point of access for information regarding host server resources of
interest to installadm.
usr/src/cmd/installadm/utils/host_server.py
usr/src/cmd/installadm/utils/test/test_host_server.py
The tests currently only run on a system where the Install SMF Service
has been installed. Any suggestions for how to best exercise these tests
where the Inistall SMF Service is not install are very much appreciated.
As development of more components is solidified this class can be expanded.
dbbase:
-------
dbbase.py provides dictionary style access to configuration file data or
string data. I realize I could update it to be derived from
collections.MutableMappings but because it had been implemented as
derived from dict I felt it not worth the effort to redo it.
This is a hold over from the current installadm implementation but has
been moved from isntalladm_common.py to dbbase.py, simplified a bit and
tests have been added.
usr/src/cmd/installadm/utils/dbbase.py
usr/src/cmd/installadm/utils/test/test_dbbase.py
Test coverage is over 90%
Thank you for your help!
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
