On 12/ 2/10 04:08 PM, [email protected] wrote:
This is preliminary code review request for a selection of code for the
Install Service Image Management project.
The ISIM project design document can be found here:
http://hub.opensolaris.org/bin/view/Project+caiman/AI+Image+Management
The webrev can be found here:
http://cr.opensolaris.org/~joev/ISIM_2_DEC_2010/
Please provide feedback by the two weeks from today, Thursday 16.Dec.2010.
For this round of review input please focus on only the following bits:
ai_image:
---------
This code provides a single interface for managing either ISO or pkg(5)
based AI images.
usr/src/cmd/installadm/utils/ai_image.py
usr/src/cmd/installadm/utils/test/test_ai_image.py
Code coverage is over 80%
dbbase:
-------
This functionality is currently provided in installadm_common.py It has
been moved to a separate module, simplified a little and tests a have
been added.
dbbase provides dictionary style access to both system configuration
files and data in string format. I realize it might be better to
implement this as a Mutable Mapping but it had already been implemented
as derived from dict.
usr/src/cmd/installadm/utils/dbbase.py
usr/src/cmd/installadm/utils/test/test_dbbase.py
Code coverage is over 90%
host_service:
-------------
Currently only a skeleton this module will be used to provide a
centralized access point to resources available on the host server.
usr/src/cmd/installadm/utils/host_server.py
usr/src/cmd/installadm/utils/test/test_host_server.py
Test currently only run on a system with the Install SMF service is
available. I have considered having setUp install a dummy SMF service so
tests can be run on build systems. Any suggestions for running these
tests on the build system are appreciated.
Thank you!
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
FYI: For testing on the build systems I am investigating having a test
install SMF service named: svc:/system/install/test_server:testing
This seems to be viable by may be overkill.
What do others think?
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
