Alok:
It looks fine and my comments are mainly nits.
Since you change the pre_pkg_img_mod.py file, it will be good if you can
fix the following pep8 audit failures:
/usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pre_pkg_img_mod.py:50:1:
E302 expected 2 blank lines, found 1
class PrePkgImgMod(Checkpoint):
^
/usr/lib/python2.6/vendor-packages/solaris_install/distro_const/checkpoints/pre_pkg_img_mod.py:373:1:
E302 expected 2 blank lines, found 1
class LiveCDPrePkgImgMod(PrePkgImgMod, Checkpoint):
Other than that, everything looks fine.
On 03/10/11 04:38 PM, Alok Aggarwal wrote:
Could I please get a couple of people to review
the following for me?
7013389 Failing unit tests in test_create_iso
025557 pre_pkg_img_mod needs to not be a has/bin
Webrev:
http://cr.opensolaris.org/~aalok/7013389-7025557/
Thanks,
Alok
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
