On 03/28/11 08:51, Dave Miner wrote:
On 03/25/11 11:51 PM, Ethan Quach wrote:
Can I get a review for the following bugs:
BugIDs:
----------
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7029179
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7027956
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7024643
Webrev:
----------
http://cr.opensolaris.org/~equach/webrev.7029179.7027956.7024643/
check-server-setup.sh, 143: s/broadcasted/advertised/
installadm-common.sh, 1072: s/form/from/
thanks.
Also, it's a little troubling that there isn't any error checking of
the result of the umount or mount operations here, but I guess you
haven't made it any worse and ISIM should be handling this differently
anyway.
yeah, I did speak to keith offline about this, and ISIM is going to be
refactoring this setup functionality, so I didn't want to spend too much
time there.
In case you were wondering, the reason why this is an issue now is
because when the umount/mount fails, it causes stderr messages from
create-client.py which in turn causes the whole command to be viewed as
a failure.
Having messages thrown on stderr didn't cause create-client to fail
before; we only recently made a change to call the create-client.py
script using run_cmd() from installadm.py. run_cmd() fails if there's
any output to stderr.
So I'm just making the changes so that the umount/mount isn't called
anymore for the cases where the filesystem is already mounted at where
it's expected to be mounted, which should be the case in normal usage.
thanks,
-ethan
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
