Hi Drew,

I think that you're missing the '/' in '/dev/dsk' on line 80.

I tried it manually and as written now it would result in a "/c0t0d0" as the
value for ctd.

Thanks,

Darren.

On 01/07/2011 03:41, Drew Fisher wrote:
> Good evening,
> 
> Could I please get a code review for the following bug:
> 
> 7061273 <http://monaco.us.oracle.com/detail.jsf?cr=7061273> get_curr_bootdisk
> makes incorrect assumptions about the ctd path returned by libdevinfo
> 
> https://cr.opensolaris.org/action/browse/caiman/drewfish/7061273/webrev/
> 
> This, folks, is why you shouldn't always trust split() and partition().  You
> should explicitly test your calls to split() and partition() and not assume
> things just worked. 
> 
> I copied the proto directory over to the t3 machine that was showing the
> problem.  After setting my PYTHONPATH to that directory, I was able to cleanly
> run target discovery.
> 
> Thanks.
> 
> -Drew
> 
> 
> 
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to