Dermot and Darren,
Thanks for the review. I've implemented both suggestions.
-Drew
On 7/1/11 4:01 AM, Dermot McCluskey wrote:
Hi Drew,
I agree with Darren's comment about the trailing '/'.
Also, while you're modifying that function, it would be
good to explicitly return None at the end, rather than
relying on Python automatically doing so.
- Dermot
On 07/ 1/11 03:41 AM, Drew Fisher wrote:
Good evening,
Could I please get a code review for the following bug:
7061273 <http://monaco.us.oracle.com/detail.jsf?cr=7061273>
get_curr_bootdisk makes incorrect assumptions about the ctd path
returned by libdevinfo
https://cr.opensolaris.org/action/browse/caiman/drewfish/7061273/webrev/
This, folks, is why you shouldn't always trust split() and
partition(). You should explicitly test your calls to split() and
partition() and not assume things just worked.
I copied the proto directory over to the t3 machine that was showing
the problem. After setting my PYTHONPATH to that directory, I was
able to cleanly run target discovery.
Thanks.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
