Hi John,
Could need explicit backslash for line continuation to keep current
indentation?
Due to the removal of _(), the string is no longer in parentheses.
Other than that, LGTM.
Thanks,
Takeshi
On 2011年08月31日 09:51, John Fischer wrote:
All,
The updated webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-2/
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-diff/
Thanks,
John
On 08/30/11 05:28 PM, John Fischer wrote:
Mary,
I did not see that in the CR. I'll remove the translation and update
the webrev.
Thanks,
John
On Aug 30, 2011, at 5:23 PM, Mary Ding wrote:
John:
When Takeshi-san and Dave look into this, I thought the conclusion is
the string should not be translated. So removing _() seems to be the
correct thing to do.
On 08/30/11 05:17 PM, John Fischer wrote:
All,
Can I get a couple of reviews of the changes for:
7076946 Build warning on conv_sysidcfg.py:1503
http://monaco.us.oracle.com/detail.jsf?cr=7076946
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946/
The fix is straight forward. The code simply adds named
arguments for the format string.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
