Thanks!! John
On Sep 1, 2011, at 5:20 AM, Dermot McCluskey wrote: > Sorry - I didn't realize you were waiting for me: > > LGTM, too. > > - Dermot > > > On 08/31/11 22:42, John Fischer wrote: >> Thanks Mary. I'll push as soon as I hear back from Dermot. >> >> >> John >> >> On 08/31/11 02:38 PM, Mary Ding wrote: >>> John: >>> >>> LGTM and thanks for fixing this. >>> >>> >>> >>> On 08/31/11 06:23 AM, John Fischer wrote: >>>> Updated webrev located at: >>>> >>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-3/ >>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-diff-2/ >>>> >>>> Thanks, >>>> >>>> John >>>> >>>> On 08/31/11 06:04 AM, John Fischer wrote: >>>>> Yep. I need a backslash. I've added it. >>>>> >>>>> John >>>>> >>>>> On 08/31/11 02:46 AM, Dermot McCluskey wrote: >>>>>> >>>>>> >>>>>> On 08/31/11 05:51, Mary Ding wrote: >>>>>>> John and Takeshi-san: >>>>>>> >>>>>>> You definitely need explicit backslash in order for this to work. >>>>>> >>>>>> backslash or "dummy" parenthesis: >>>>>> >>>>>> 1503 xpath = ("./property_group[@name='%s']" >>>>>> 1504 "[type='%s']" % (propgrp_name, propgrp_type)) >>>>>> >>>>>> - Dermot >>>>>> >>>>>> >>>>>>> ----- Original Message ----- >>>>>>> From: [email protected] >>>>>>> To: [email protected] >>>>>>> Cc: [email protected] >>>>>>> Sent: Tuesday, August 30, 2011 7:53:15 PM GMT -08:00 Tijuana / Baja >>>>>>> California >>>>>>> Subject: Re: [caiman-discuss] webrev for CR 7076946 >>>>>>> >>>>>>> Hi John, >>>>>>> >>>>>>> Could need explicit backslash for line continuation to keep current >>>>>>> indentation? >>>>>>> Due to the removal of _(), the string is no longer in parentheses. >>>>>>> >>>>>>> Other than that, LGTM. >>>>>>> >>>>>>> Thanks, >>>>>>> Takeshi >>>>>>> >>>>>>> On 2011年08月31日 09:51, John Fischer wrote: >>>>>>>> All, >>>>>>>> >>>>>>>> The updated webrev is located at: >>>>>>>> >>>>>>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-2/ >>>>>>>> >>>>>>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946-diff/ >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> John >>>>>>>> >>>>>>>> On 08/30/11 05:28 PM, John Fischer wrote: >>>>>>>>> Mary, >>>>>>>>> >>>>>>>>> I did not see that in the CR. I'll remove the translation and update >>>>>>>>> the webrev. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> >>>>>>>>> John >>>>>>>>> >>>>>>>>> On Aug 30, 2011, at 5:23 PM, Mary Ding wrote: >>>>>>>>> >>>>>>>>>> John: >>>>>>>>>> >>>>>>>>>> When Takeshi-san and Dave look into this, I thought the conclusion is >>>>>>>>>> the string should not be translated. So removing _() seems to be the >>>>>>>>>> correct thing to do. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 08/30/11 05:17 PM, John Fischer wrote: >>>>>>>>>>> All, >>>>>>>>>>> >>>>>>>>>>> Can I get a couple of reviews of the changes for: >>>>>>>>>>> >>>>>>>>>>> 7076946 Build warning on conv_sysidcfg.py:1503 >>>>>>>>>>> http://monaco.us.oracle.com/detail.jsf?cr=7076946 >>>>>>>>>>> >>>>>>>>>>> The webrev is located at: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> https://cr.opensolaris.org/action/browse/caiman/johnfisc/7076946/ >>>>>>>>>>> >>>>>>>>>>> The fix is straight forward. The code simply adds named >>>>>>>>>>> arguments for the format string. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> John >>>>>>>>>>> >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> caiman-discuss mailing list >>>>>>>>>>> [email protected] >>>>>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>>>>> _______________________________________________ >>>>>>>>> caiman-discuss mailing list >>>>>>>>> [email protected] >>>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>>>> _______________________________________________ >>>>>>>> caiman-discuss mailing list >>>>>>>> [email protected] >>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>>> _______________________________________________ >>>>>>> caiman-discuss mailing list >>>>>>> [email protected] >>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>>> _______________________________________________ >>>>>>> caiman-discuss mailing list >>>>>>> [email protected] >>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>>> _______________________________________________ >>>>>> caiman-discuss mailing list >>>>>> [email protected] >>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
