Hi Drew,
Thank you for the code review. Please see my comments inline.
On 08/31/11 16:09, Drew Fisher wrote:
Karen,
ti_target_utils.py
928, 1264: if not existing_gaps:
Fixed as suggested.
partition_edit_screen.py
Do we have a CR filed on the issue with the target controller which
presents disks with in_zpool set? I assume you're not fixing the
controller issue as nobody can quite remember WHY in_zpool gets set
the way it does?
I do not have a CR filed for that problem. I just made changes to
workaround that problem.
Let me file one.
Thanks.
--Karen
Otherwise, this looks fine to me.
-Drew
On 8/31/11 4:03 PM, Karen Tung wrote:
I would like get a couple of reviews for changes to fix the following
bugs:
7083584 <http://monaco.us.oracle.com/detail.jsf?cr=7083584> snv 172 text
installer does not initially present SAS drive aliases/receptacles
7083367 <http://monaco.us.oracle.com/detail.jsf?cr=7083367> composed string have
localization issue: _("The new size ") + locale_new_size + _(" is greater ...
7082485 <http://monaco.us.oracle.com/detail.jsf?cr=7082485> AI install fails
when dump zvol specified in manifest.
7081220 <http://monaco.us.oracle.com/detail.jsf?cr=7081220> S11 TI crashes
after configuring on partitioning screen-'no Solaris partition found'
7064286 <http://monaco.us.oracle.com/detail.jsf?cr=7064286> [Text Installer]
Installation restarts when partitions are changed.
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/text-installer-bugs/webrev/
I tested by building SPARC and X86 AI images, and performed installs
with these
images to make sure the dependency of auto-installer SMF service on
svc:/system/devchassis:daemon doesn't affect anything. I also did
installs
via custom manifests that specifies to create swap/dump zvols.
Text Installer images are also built to verify the dependency on
devchassis:daemon doesn't cause any problems. Then,
I tried different scenario in the text installer UI and and verify all
the problems reported in the bugs are fixed.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
