Hi Karen,
Thanks for making that change.
It all looks good now.
- Dermot
On 09/01/11 19:50, Karen Tung wrote:
Hi Dermot,
Thank you for the code review. Please see my comments inline.
I have updated the code and posted an updated webrev. Please take
a look and confirm you are ok with the updated changes.
https://cr.opensolaris.org/action/browse/caiman/ktung/text-installer-bugs-updated/webrev/
On 09/01/11 05:53, Dermot McCluskey wrote:
Karen,
One nit:
ti_target_utils.py line 938: while you are changing this
statement, you should correct typo: "unsed" -> "unused"
Fixed.
And a question:
ti_target_utils.py line 936: do you not need to apply a minimum
size requirement to the largest gap found, as you do in
add_missed_parts()? eg if the largest gap found was 0.5GB,
do you still want to allow a Solaris2 partition to be created on it?
That's a good point. I added code to ignore gaps that are smaller than
1G for primary partitions and slices, and smaller than 0.1G for
logical partitions.
Basically, I use the same rules I used for the add_missed_parts() function
so everything is consistent.
Thanks,
--Karen
- Dermot
On 08/31/11 23:03, Karen Tung wrote:
I would like get a couple of reviews for changes to fix the
following bugs:
7083584 <http://monaco.us.oracle.com/detail.jsf?cr=7083584> snv 172 text
installer does not initially present SAS drive aliases/receptacles
7083367 <http://monaco.us.oracle.com/detail.jsf?cr=7083367> composed string have
localization issue: _("The new size ") + locale_new_size + _(" is greater ...
7082485 <http://monaco.us.oracle.com/detail.jsf?cr=7082485> AI install fails
when dump zvol specified in manifest.
7081220 <http://monaco.us.oracle.com/detail.jsf?cr=7081220> S11 TI crashes
after configuring on partitioning screen-'no Solaris partition found'
7064286 <http://monaco.us.oracle.com/detail.jsf?cr=7064286> [Text Installer]
Installation restarts when partitions are changed.
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/text-installer-bugs/webrev/
I tested by building SPARC and X86 AI images, and performed installs
with these
images to make sure the dependency of auto-installer SMF service on
svc:/system/devchassis:daemon doesn't affect anything. I also did
installs
via custom manifests that specifies to create swap/dump zvols.
Text Installer images are also built to verify the dependency on
devchassis:daemon doesn't cause any problems. Then,
I tried different scenario in the text installer UI and and verify all
the problems reported in the bugs are fixed.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
