Thanks Dermot!! John
On 09/ 2/11 03:33 AM, Dermot McCluskey wrote:
John, Subject to answering Takeshi's questions: this looks fine to me. - Dermot On 09/02/11 03:57, John Fischer wrote:All, Can I get a couple of reviews for the fix for CR 7082668: 7082668 gui-install displays always in English http://monaco.us.oracle.com/detail.jsf?cr=7082668 The webrev is located at: https://cr.opensolaris.org/action/browse/caiman/johnfisc/7082668/ The fix to correct the reported issue is fairly start forward. The code that sets up the localization is being moved from the solaris_install/sysconfig/__init__.py file to the /usr/sbin/sysconfig file. During testing I discovered that the raw_input() function was pucking. Takeshi explained that it was because raw_input() accepts an argument string in either unicode or str. But in our case unicode was given, thus raw_input() looks to encode it internally (to pass it to I/O), and in that case, the system-wide default encoding ASCII is assumed. The given string is in Spanish and contains non-ASCI characters so the ASCII encoder cannot handle the characters. So the fix is to get the encoding and then encode it for the raw_input() functions. Takeshi was hugely helpful in this part of the issue. So I have tested the fixes with the GUI Installer and it works there. I have tested it using sysconfig configure and when the system changes to the configure milestone it comes up in the correct locale. Thanks, John _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
