Hi --
Sanjay requested to provide a code review.
He is concerned about the visibility of the groupings
in the error message for create-profile and asked me to change it
to reflect "system".
I figure this is temporary until we reinstate the groupings,
so I just inserted it in place. here is the updated webrev:
https://cr.opensolaris.org/action/browse/caiman/ginnie/7087609/webrev/
This is my test. Here is the new code:
root@solaris:~# sysconfig create-profile -g blah
Usage: sysconfig unconfigure [-s] [-g system] [--destructive]
sysconfig configure [-s] [-g system] [-c config_profile.xml |
dir] [--destructive]
sysconfig create-profile [-g system] [-o output_file] [-l
logfile] [-v verbosity] [-b]
sysconfig: error: system is the only supported grouping
Just to reiterate, if a user types correctly:
sysconfig create-profile -g identity
the SCI tool will come up. (Checked the change....I'm very paranoid at
this point).
Here was how it would appear w/o Sanjay's suggestion....
The previous error output printed all the groupings. This will mask them
from
users and minimize confusion.
root@solaris:~# sysconfig create-profile -g blah
Usage: sysconfig unconfigure [-s] [-g system] [--destructive]
sysconfig configure [-s] [-g system] [-c config_profile.xml |
dir] [--destructive]
sysconfig create-profile [-g system] [-o output_file] [-l
logfile] [-v verbosity] [-b]
sysconfig: error: Grouping must be one of identity network
naming_services kbd_layout location date_time users system
Let me know if this will be acceptable and if I have permission to push.
thanks,
ginnie
On 09/ 7/11 09:55 AM, Dave Miner wrote:
OK, I'm satisfied with the code, you're approved.
Dave
On 09/07/11 11:44, Virginia Wray wrote:
On 09/ 7/11 09:18 AM, Dave Miner wrote:
On 09/07/11 11:11, Virginia Wray wrote:
Hi --
This is a stopper bug that I would like to get back quickly, so
that we can redeliver for build 174.
Jan has code reviewed. Can I get one more reviewer
and Dave's ok?
CR:
http://monaco.us.oracle.com/detail.jsf?cr=7087609
Webrev:
file:///net/indiana-build.us.oracle.com/data/share/vw130254/projectwork/sys-unconfig/7087609/slim_source/webrev/index.html
Just to be clear, the end result here is that create-profile still
works for whatever groupings are specified, and configure and
unconfigure still only work with system? And you've tested that,
right? :-)
Dave
yes. I tested all three cases with my fix last night. (I don't blame you
for asking. :) )
create-profile and the configure/unconfigure paths are different...
If you look in the code review, if the sub_cmd is create_profile (line
514),
it checks to make sure the groupings requested are valid. This is
actually
what was broken, since the svccfg command was now only returning
"system".
The else portion (line 523) is for the configure/unconfigure case. It
doesn't
allow anything but "system". This wasn't broken. The reason the
configure was
breaking is because the config milestone calls sysconfig create-profile.
thanks,
ginnie
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
