On 09/07/11 13:17, Virginia Wray wrote:
Hi --
Sanjay requested to provide a code review.
He is concerned about the visibility of the groupings
in the error message for create-profile and asked me to change it
to reflect "system".
I figure this is temporary until we reinstate the groupings,
so I just inserted it in place. here is the updated webrev:
https://cr.opensolaris.org/action/browse/caiman/ginnie/7087609/webrev/
This is my test. Here is the new code:
root@solaris:~# sysconfig create-profile -g blah
Usage: sysconfig unconfigure [-s] [-g system] [--destructive]
sysconfig configure [-s] [-g system] [-c config_profile.xml | dir]
[--destructive]
sysconfig create-profile [-g system] [-o output_file] [-l logfile] [-v
verbosity] [-b]
sysconfig: error: system is the only supported grouping
Just to reiterate, if a user types correctly:
sysconfig create-profile -g identity
the SCI tool will come up. (Checked the change....I'm very paranoid at
this point).
Here was how it would appear w/o Sanjay's suggestion....
The previous error output printed all the groupings. This will mask them
from
users and minimize confusion.
root@solaris:~# sysconfig create-profile -g blah
Usage: sysconfig unconfigure [-s] [-g system] [--destructive]
sysconfig configure [-s] [-g system] [-c config_profile.xml | dir]
[--destructive]
sysconfig create-profile [-g system] [-o output_file] [-l logfile] [-v
verbosity] [-b]
sysconfig: error: Grouping must be one of identity network
naming_services kbd_layout location date_time users system
Let me know if this will be acceptable and if I have permission to push.
But create-profile accepts the other groupings, so we're just as likely
to get a bug about the incorrect error message here. I don't see the
harm in leaving that message as it was.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
