On 12/19/11 09:00 AM, Tomas Dzik wrote:
Hi Sue,
thanks a lot for your comments. I fixed the error messages as you suggested,
new webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7083848-2/
Could you please review it ?
You don't need the '+' on lines 525, 526, and 528.
Otherwise, looks good. No need for new webrev.
Sue
PS: New output:
root@S11:~# installadm create-service -n test1 -s /tmp/noexist.isoWarning:
Automatic network
configuration is enabled. Please be sure that the IP address for S11 is static.
Creating service from: /tmp/noexist.iso
OK to use default image path: /export/auto_install/test1? [y/N]: y
The specified data source for the service, /tmp/noexist.iso, is not a
path to an existing ISO image.
Attempting to create the service from pkg(5) package,
/tmp/noexist.iso, failed for the following reasons:
The following pattern(s) did not match any allowable packages. Try
using a different matching pattern, or refreshing publisher information:
/tmp/noexist.iso
Dne 19.12.11 17:16, Sue Sohn napsal(a):
On 12/19/11 04:39 AM, Tomas Dzik wrote:
Hi all,
I would like to ask you for a code review for a bug:
7083848 - installadm create-service generates confusing error messages
if non-existent iso specified
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7083848/
Testing:
1) Source is pep8 clean
2) The new output if non-existent iso is specified:
root@S11:~# installadm create-service -n test1 -s /tmp/noexist.iso
Warning: Automatic network configuration is enabled. Please be sure
that the IP address for S11 is
static.
Creating service from: /tmp/noexist.iso
OK to use default image path: /export/auto_install/test1? [y/N]: y
The specified data source for the net image /tmp/noexist.iso is not
path to the existing ISO image.
Attempt to create net image from pkg(5) package /tmp/noexist.iso
failed from following reasons:
The following pattern(s) did not match any allowable packages. Try
using a different matching pattern, or refreshing publisher information:
/tmp/noexist.iso
Hi Tomas,
This basically looks good, but I'd suggest tweaking the error messages
to read:
The specified data source for the service, /tmp/noexist.iso, is not a
path to an existing ISO image.
Attempting to create the service from pkg(5) package, /tmp/noexist.iso,
failed for the following reasons:
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
