Hi Tomas.
Looks good except for one thing John pointed out. I wanted to explain
as this has bit me in the past too...
Doing this:
_("first part of sentence") + options.srcimage + _("last part")
makes it hard for the translation team to deal with, since some
languages shuffle the parts of the sentence around.
For example, English has a verb in the middle of a sentence whereas some
Asian languages have it at the end.
Combining all parts into a single "_()" call make a single item which
the translation team can translate as one unit:
_("first part of sentence %s last part")
Thanks,
Jack
P.S. If you have multiple arguments, use a dictionary to store them:
print "%(arg1)s %(arg2)s" % {"arg1": "Hello", "arg2": "Tomas"}
On 12/19/11 04:39 AM, Tomas Dzik wrote:
Hi all,
I would like to ask you for a code review for a bug:
7083848 - installadm create-service generates confusing error messages
if non-existent iso specified
Webrev:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7083848/
Testing:
1) Source is pep8 clean
2) The new output if non-existent iso is specified:
root@S11:~# installadm create-service -n test1 -s /tmp/noexist.iso
Warning: Automatic network configuration is enabled. Please be sure
that the IP address for S11 is static.
Creating service from: /tmp/noexist.iso
OK to use default image path: /export/auto_install/test1? [y/N]: y
The specified data source for the net image /tmp/noexist.iso is not
path to the existing ISO image.
Attempt to create net image from pkg(5) package /tmp/noexist.iso
failed from following reasons:
The following pattern(s) did not match any allowable packages. Try
using a different matching pattern, or refreshing publisher information:
/tmp/noexist.iso
Best regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
