Niall,
Review of GUI section:
*
GUI: Darren, Dermot
---------------------------*
*
*usr/src/cmd/gui-install/src/Makefile
usr/src/cmd/gui-install/src/confirm_screen.py
186...
FYI - the app will never see disk.whole_disk set to True
in the VTOC world: if you select a disk with TargetController
and set use_whole_disk=True, it will add a default layout
and set disk.whole_disk = False before passing back to
the app.
It looks like you are handling things slightly differently
for GPT?
Also, if you move 202-203 to before 185, then you can
combine the two separate "if" statements at lines 186 and 205.
usr/src/cmd/gui-install/src/disk_panel.py
usr/src/cmd/gui-install/src/disk_screen.py
is line 147 needed, given line 150?
usr/src/cmd/gui-install/src/fdisk_panel.py
126 builder.add_from_file(GLADE_DIR + "/" + FDISK_GLADE)
Why not do this in ScreenManager.__init__(), like all the other
Glade files? Also, connecting reset button(s) could be done
in ScreenManager, as before?
Same goes for gpt_panel.py.
usr/src/cmd/gui-install/src/gpt_panel.py
Did you have a look at refactoring this code so some of it
could be shared with fdisk_panel.py, eg by moving it to
disk_panel.py?
It seems a lot of it is identical.
usr/src/cmd/gui-install/src/screen_manager.py
usr/src/cmd/gui-install/xml/Makefile*
*usr/src/pkg/manifests/system-install-gui-install.mf *
*
*
I seriously wouldn't bother code reviewing these glade auto-generated
XML files but if you enjoy pulling your eyes out :)*
I took a quick look, anyway:
did you mean to remove/not add CDDL headers?
usr/src/cmd/gui-install/xml/fdisk-panel.xml
usr/src/cmd/gui-install/xml/gpt-panel.xml
usr/src/cmd/gui-install/xml/installationdisk.xml
375 - when renamingcustompartioningalignment
the "i" in partition was removed:custompartitonalignment
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
