On Dec 22, 2011, at 7:38 AM, Darren Kenny wrote:
> […]
>
> usr/src/cmd/auto-install/checkpoints/target_selection.py;
>
> - lines 1150-1154 and 1156-1160
>
> I'm fairly sure we could remove the need to do this condition check
> twice. Possibly using a temporary variable to store the size.
Agreed, and fixed.
>
> - lines 1805 to 1811
>
> Are these lines commented out intentionally? If so, why?
Matt caught that too. Not intentional, uncommented.
>
> - lines 2000-2003
>
> The error refers to slices - what terminology should we be using here?
> Given that we have gpt_partitions in the DTD, seems wrong to to refer to
> them as such in the errors too…
Changed wording to:
Could not find root pool slice or GPT Partition on any disk. Valid
Solaris installations must contain at least one root pool slice/GPT Partition.
>
> usr/src/lib/install_common/__init__.py:
>
> - lines 478-490:
>
> Why aren't we using the built in os.sysconf() method to get the
> pagesize, and number of pages, e.g.:
>
> $ python
> >>> import os
> >>> print os.sysconf('SC_PAGESIZE')
> 4096
> >>> print os.sysconf('SC_PHYS_PAGES')
> 1957677
Because I didn't realize that existed. Darren++
Changing to use os.sysconf().
>
> […]
>
> usr/src/lib/install_target/shadow/__init__.py:
>
> - lines 124-126:
>
> These should probably be removed.
Done
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
