Thanks, Sue. I appreciate the feedback. Comments inline. I will
publish another webrev when I have incorporated Dave's suggested change.
Harold
On 12/29/11 08:49, Susan Sohn wrote:
On 12/28/11 02:00 PM, Harold Shaw wrote:
May I get a code review for the following installadm bugs:
7060060 Informational message to report bad image should include
service name
5393 Automated Installer should not allow setting up non-AI images
and should check validity of image
7090169 installadm list doesn't detect when the image directory has
been removed
Webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/5393
Testing:
Create an AI service from a valid ISO
Create an AI service from a valid package
Attempt to create AI service from ISO with:
- no solaris.zlib
- no auto_install/ai.dtd
This was done by attempting to create a service from a text install
iso and a hand modified iso (to
get rid of solaris.zlib).
Disable and enable valid services
Disable valid services, make them invalid (remove the image dir, get
rid of auto_install or
solaris.zlib), and then attempt to enable them
installadm list
remove image directory, run installadm list, and verify that it runs
successfully replacing the Arch
value with '-'
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Harold,
create_service.py
517 remove line
520 did you want to add ignore_errors=True in rmtree call?
521 suggested reword, Please re-enter command and specify a valid
Automated Installer ISO file.
Done.
image.py
77 You've renamed NO_ZLIB here and on 104 but NO_ZLIB is also defined
in InstalladmPkgImage so you'll need a change there too to pick up the
right string for the verify call. You might also add a test to create
a "bad" solaris-auto-install package to make sure the error handling
still works for the pkg case.
78 Installation -> Installer
89 ditto
Done and tested.
service.py
685 It might read better if you display the service name and then the
error, rather than the other way around.
Done.
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
