On 01/ 3/12 02:06 PM, Harold Shaw wrote:
May I get a re-review for the following installadm bugs:
7060060 Informational message to report bad image should include service name
5393 Automated Installer should not allow setting up non-AI images and should
check validity of image
7090169 installadm list doesn't detect when the image directory has been removed
I changed the output for 'installadm list' and 'installadm list -c' as follows
for the case where
the service image directory is not available to look up the architecture.
Everything lines up when
printed to the screen.
root@x2270-brm-03:/export# installadm list -c
Service Name Client Address Arch Image Path
------------ -------------- ---- ----------
s11u1_iso_2 01:02:03:04:05:06 * /export/iso_2
* - Architecture unknown, service image does not exist or is
inaccessible.
root@x2270-brm-03:/export# installadm list
Service Name Alias Of Status Arch Image Path
------------ -------- ------ ---- ----------
default-i386 s11u1_pkg on * /export/auto_install/s11u1_pkg
s11u1_iso - on i386 /export/auto_install/s11u1_iso
s11u1_iso_2 - on * /export/iso_2
s11u1_pkg - on * /export/auto_install/s11u1_pkg
solaris11u1-i386-05 - on i386 /export/auto_install/solaris11u1-i386-05
solaris11u1-i386-06 - on i386 /export/auto_install/solaris11u1-i386-06
* - Architecture unknown, service image does not exist or is
inaccessible.
Webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/5393_1
Testing:
Create an AI service from a valid ISO
Create an AI service from a valid package
Attempt to create AI service from ISO with:
- no solaris.zlib
- no auto_install/ai.dtd
This was done by attempting to create a service from a text install iso and a
hand modified iso (to
get rid of solaris.zlib).
Disable and enable valid services
Disable valid services, make them invalid (remove the image dir, get rid of
auto_install or
solaris.zlib), and then attempt to enable them
installadm list & installadm list -c
remove image directory, run installadm list, and verify that it runs
successfully printing the Arch
value as '*'
Created service image packages (using pkgrecv & pkgmogrify) with:
- no solaris.zlib
- no auto_install/ai.dtd
and attempted to create services from them. This was to verify that the
original error message would
still be printed.
Hi Harold,
Happy New Year. Please update copyright to 2012 for all files. :)
image.py
225 change "autoinstall image" to "Automated Installer image" to be
consistent with line 78
list.py
119 Previously, which_arch() returned 'x86' or 'Sparc' and now it returns (and outputs) 'i386' and
'sparc'. Is this intentional? If so, manpage examples and docs will need update.
129-130 comments need to be updated
184 and 478 add comma after "identified"
191 and 494 Suggest defining this string at the top of the file since it is
used in a couple of places
service.py
682 add-> prepend
685 Now that you have the service name first, you should remove the tab before
"Service Name"
Also, it looks like the ImageError strings may already start with a newline, so you may not
want the newline after the service name
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
