Nirmal:

This is mainly a nit, since you are changing usr/src/lib/install_target/logical.py, can you fix the following pylint unused imports:

The following lines should be removed:

from solaris_install.target.libbe.const import ZFS_FS_NAMES, \
    ZFS_SHARED_FS_NAMES



On 02/12/12 21:12, Nirmal Agarwal wrote:
Hi all

Could I please get a code review for the following CR:

7070697 size element for zvols should be optional

Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7070697/webrev/

slim_test result
----------------
/net/indiana-build.us.oracle.com//export/home/na210770/ai/7070697/slim_test

Manual Tests :

-- created a custom image and tested the fix with the manifest not
   describing the size of zvol.


Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to